Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

chore: move baggage methods in propagation namespace #55

Merged
merged 2 commits into from
May 14, 2021

Conversation

vmarchaud
Copy link
Member

Since we moved the span context method into trace namespace, i'm also proposing to move [create/get/set]Baggage into the propagation namespace.

We still export baggageEntryMetadataFromString which feels kinda wrong to me since it doesn't do anything apart creating a unusued object, could we have a less strict type for the metadata so we don't need this function ?

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #55 (9268926) into main (0a3bee4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   94.62%   94.66%   +0.04%     
==========================================
  Files          40       40              
  Lines         502      506       +4     
  Branches       80       80              
==========================================
+ Hits          475      479       +4     
  Misses         27       27              
Impacted Files Coverage Δ
src/api/propagation.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3bee4...9268926. Read the comment docs.

@vmarchaud vmarchaud marked this pull request as ready for review May 13, 2021 10:12
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the methods will be available under propagation namespace instead of global, i think you should add info to Upgrade Guidelines, other than that lgtm

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with bart you should update the upgrade guidelines. Other than that LGTM so I will approve

@vmarchaud vmarchaud force-pushed the namespaced-baggage branch from 0d5668d to 9268926 Compare May 14, 2021 07:25
@vmarchaud vmarchaud requested a review from obecny May 14, 2021 07:26
@vmarchaud
Copy link
Member Author

@obecny I rebased + added the upgrade guideline, PTAL

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants