Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

docs(api): update earliest supported node version #159

Conversation

svetlanabrennan
Copy link

Signed-off-by: Svetlana Brennan [email protected]

Partially fixes Issue #2721

  • See checklist item 1 mentioned here

@svetlanabrennan svetlanabrennan requested a review from a team April 5, 2022 18:24
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change this on the API without a major bump ?

EDIT: I understand that the SDK requires 8.12 for correct timestamp but the api do not right ?

@Flarna
Copy link
Member

Flarna commented Apr 6, 2022

I did a quick look and it seems API is not using perf_hooks so it will even work with node.js 8.0.0.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #159 (aaca63c) into main (bafcf0d) will not change coverage.
The diff coverage is n/a.

❗ Current head aaca63c differs from pull request most recent head 214f352. Consider uploading reports for the commit 214f352 to get more accurate results

@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          45       45           
  Lines         646      646           
  Branches      102      102           
=======================================
  Hits          615      615           
  Misses         31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bafcf0d...214f352. Read the comment docs.

@vmarchaud
Copy link
Member

I did a quick look and it seems API is not using perf_hooks so it will even work with node.js 8.0.0.

API should be platform agnostic anyway so we should keep the support i think

@rauno56
Copy link
Member

rauno56 commented Apr 21, 2022

I did a quick look and it seems API is not using perf_hooks so it will even work with node.js 8.0.0.

That's right. @svetlanabrennan, perhaps we can close this PR then as technically API is not restricted.

@vmarchaud vmarchaud closed this Apr 21, 2022
@svetlanabrennan svetlanabrennan deleted the update-supported-node-versions branch April 21, 2022 15:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants