Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Add source map files to builds #134

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Conversation

necrolyte2
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #134 (80d1f8d) into main (35582a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          42       42           
  Lines         578      578           
  Branches       94       94           
=======================================
  Hits          546      546           
  Misses         32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35582a7...80d1f8d. Read the comment docs.

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but i think we discussed this before, relating to the size of the bundle that we publish, could you compare before/after ?

@necrolyte2
Copy link
Contributor Author

Hopefully this is correct

rm -rf build
npm run compile

# Generate All files
du -hs build/*

# Generate only specific files
find build/esm \( -name '*.js' -o -name '*.js.map' -o -name '*.d.ts' \) -exec du -ch {} +
find build/src \( -name '*.js' -o -name '*.js.map' -o -name '*.d.ts' \) -exec du -ch {} +

ESM

Tool Before After
All files 856K 900K
Only js, js.map, d.ts 628K 672K

CommonJS

Tool Before After
All Files 840K 884K
Only js, js.map, d.ts 632K 676K

NPM Pack(npm pack)

Size Type Before After
Packed 58.1kB 81.1 kB
Unpacked 377 kB 595.6 kB

@vmarchaud
Copy link
Member

cc @MSNev i'm not that familiar with the browser tooling, do you find it acceptable ?

@vmarchaud vmarchaud added the enhancement New feature or request label Nov 17, 2021
@vmarchaud vmarchaud merged commit 3c4364b into open-telemetry:main Nov 17, 2021
@necrolyte2 necrolyte2 deleted the patch-1 branch November 17, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants