This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
feat(trace): add optional schema url to TracerProvider.getTracer #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
dyladan,
Flarna,
johnbley,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rauno56 and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
+ Coverage 94.47% 94.67% +0.20%
==========================================
Files 42 42
Lines 579 582 +3
Branches 94 94
==========================================
+ Hits 547 551 +4
+ Misses 32 31 -1
Continue to review full report at Codecov.
|
legendecas
force-pushed
the
schema-url
branch
3 times, most recently
from
cf082aa to
13e0ab4
Compare
legendecas
force-pushed
the
schema-url
branch
from
13e0ab4 to
e897b37
Compare
legendecas
force-pushed
the
schema-url
branch
from
e897b37 to
fd0c7f1
Compare
obecny
reviewed
Nov 11, 2021
obecny
approved these changes
Nov 11, 2021
vmarchaud
approved these changes
Nov 11, 2021
|
ping @dyladan :) |
MSNev
approved these changes
Dec 8, 2021
rauno56
approved these changes
Dec 8, 2021
Merged
dyladan
reviewed
Jan 11, 2022
dyladan
approved these changes
Jan 11, 2022
|
@legendecas feel free to merge this when you're ready |
blumamir
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the conclusion at open-telemetry/opentelemetry-js#2529 (comment), the new optional parameter of
TracerProvider.getTracershould be put into an option bag to prevent from breaking existing SDK implementations. In this way, we can also reserve the possibility for future extensions.Fixes #125
Fixes open-telemetry/opentelemetry-js#2535