This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
chore: align linter rules with repo open-telemetry/opentelemetry-js #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
dyladan,
Flarna,
johnbley,
markwolff,
mayurkale22,
MSNev,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rauno56 and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 95.12% 95.11% -0.01%
==========================================
Files 42 42
Lines 574 573 -1
Branches 90 90
==========================================
- Hits 546 545 -1
Misses 28 28
Continue to review full report at Codecov.
|
vmarchaud
approved these changes
Oct 25, 2021
|
The only failed check is that codecov complains about -0.01% coverage diff :(. |
|
cc @open-telemetry/javascript-approvers could someone review this one ? its a straightforward change and its blocking other PRs |
rauno56
approved these changes
Nov 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current linter rule is not exactly the same as the one of open-telemetry/opentelemetry-js, which makes moving codes between them require unnecessary re-formats.