Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MeterSharedState with MeterProviderSharedState #875

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #875 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #875      +/-   ##
============================================
- Coverage     82.99%   82.95%   -0.04%     
  Complexity      823      823              
============================================
  Files           107      107              
  Lines          2869     2869              
  Branches        253      253              
============================================
- Hits           2381     2380       -1     
  Misses          375      375              
- Partials        113      114       +1
Impacted Files Coverage Δ Complexity Δ
.../io/opentelemetry/sdk/metrics/AbstractCounter.java 91.3% <100%> (ø) 9 <0> (ø) ⬇️
...elemetry/sdk/metrics/MeterProviderSharedState.java 100% <100%> (ø) 2 <2> (?)
.../io/opentelemetry/sdk/metrics/AbstractMeasure.java 91.3% <100%> (ø) 9 <0> (ø) ⬇️
.../opentelemetry/sdk/metrics/AbstractInstrument.java 84.48% <100%> (ø) 8 <0> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongCounterSdk.java 96.15% <100%> (ø) 4 <1> (ø) ⬇️
...o/opentelemetry/sdk/metrics/DoubleObserverSdk.java 93.75% <100%> (ø) 2 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleCounterSdk.java 96.15% <100%> (ø) 4 <1> (ø) ⬇️
...a/io/opentelemetry/sdk/metrics/LongMeasureSdk.java 96.15% <100%> (ø) 4 <1> (ø) ⬇️
...io/opentelemetry/sdk/metrics/DoubleMeasureSdk.java 96.15% <100%> (ø) 4 <1> (ø) ⬇️
...in/java/io/opentelemetry/sdk/metrics/MeterSdk.java 92.85% <100%> (ø) 10 <7> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873922a...f2804d8. Read the comment docs.

@bogdandrutu bogdandrutu force-pushed the sharedstate branch 2 times, most recently from 218ee24 to 7f56496 Compare February 19, 2020 17:26
@jkwatson
Copy link
Contributor

This seems fine, but I'm not sure why it's necessary. Is MeterSharedState not clear as to what it's about?

@bogdandrutu
Copy link
Member Author

@jkwatson I will also have a MeterSharedState which is the meter shared state between instruments which includes library info and other meter specific things.

@jkwatson
Copy link
Contributor

looks like it needs a rebase

@bogdandrutu bogdandrutu merged commit fe41166 into open-telemetry:master Feb 19, 2020
@bogdandrutu bogdandrutu deleted the sharedstate branch February 19, 2020 17:55
DotSpy pushed a commit to DotSpy/opentelemetry-java that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants