-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MeterSharedState with MeterProviderSharedState #875
Conversation
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 82.99% 82.95% -0.04%
Complexity 823 823
============================================
Files 107 107
Lines 2869 2869
Branches 253 253
============================================
- Hits 2381 2380 -1
Misses 375 375
- Partials 113 114 +1
Continue to review full report at Codecov.
|
218ee24
to
7f56496
Compare
This seems fine, but I'm not sure why it's necessary. Is MeterSharedState not clear as to what it's about? |
@jkwatson I will also have a MeterSharedState which is the meter shared state between instruments which includes library info and other meter specific things. |
looks like it needs a rebase |
Signed-off-by: Bogdan Cristian Drutu <[email protected]>
7f56496
to
f2804d8
Compare
…#875) Signed-off-by: Bogdan Cristian Drutu <[email protected]>
No description provided.