Skip to content

Add unit test codifying that view names need to conform to metric nam…#8412

Merged
jack-berg merged 4 commits into
open-telemetry:mainfrom
jack-berg:view-name-not-validated
May 19, 2026
Merged

Add unit test codifying that view names need to conform to metric nam…#8412
jack-berg merged 4 commits into
open-telemetry:mainfrom
jack-berg:view-name-not-validated

Conversation

@jack-berg

Copy link
Copy Markdown
Member

…e requirements

Codifies this clarification from the spec: open-telemetry/opentelemetry-specification#5094

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.13%. Comparing base (d39116e) to head (613896f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8412      +/-   ##
============================================
- Coverage     91.15%   91.13%   -0.02%     
+ Complexity     7762     7761       -1     
============================================
  Files           881      881              
  Lines         23408    23408              
  Branches       2330     2330              
============================================
- Hits          21337    21334       -3     
- Misses         1377     1378       +1     
- Partials        694      696       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jack-berg jack-berg merged commit 1087f5f into open-telemetry:main May 19, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants