Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasEnded to ReadableSpan and SpanData (split from #693) #733

Merged
merged 5 commits into from
Jan 7, 2020

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Jan 7, 2020

This PR was split from #693 at the request of @bogdandrutu. It just renames the internal boolean hasBeenEnded of RecordEventsReadableSpan to hasEnded, makes it public on the ReadableSpan interface and also adds it to SpanData.

@codecov-io
Copy link

Codecov Report

Merging #733 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #733      +/-   ##
============================================
+ Coverage     78.71%   78.74%   +0.02%     
- Complexity      746      747       +1     
============================================
  Files            93       93              
  Lines          2608     2611       +3     
  Branches        235      235              
============================================
+ Hits           2053     2056       +3     
  Misses          459      459              
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...main/java/io/opentelemetry/sdk/trace/SpanData.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...ntelemetry/sdk/trace/RecordEventsReadableSpan.java 89.47% <100%> (+0.18%) 49 <3> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91053c4...707117c. Read the comment docs.

@bogdandrutu bogdandrutu merged commit ff067e0 into open-telemetry:master Jan 7, 2020
@Oberon00 Oberon00 deleted the spandidend branch January 8, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants