Skip to content

Fix link checker - #7282

Merged
jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:fix-link-check
Apr 16, 2025
Merged

Fix link checker#7282
jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:fix-link-check

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Build has been failing due to this for a while.

The link check config is meant to exclude links to issues / PRs for performance reasons, but this one slipped through the cracks.

Oddly though, if you navigate to #4775 you consistently get a 500 from github, despite it indeed being the correct link to the PR. To verify the correctness, you can separately search for that specific PR and click on it from the search results to get the same result!

Weird. Anyway, fixing it so its properly excluded 🤷

@jack-berg
jack-berg requested a review from a team as a code owner April 16, 2025 16:18
@codecov

codecov Bot commented Apr 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (d13f04d) to head (c7d881d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7282   +/-   ##
=========================================
  Coverage     89.61%   89.61%           
  Complexity     6858     6858           
=========================================
  Files           780      780           
  Lines         20718    20718           
  Branches       2020     2020           
=========================================
  Hits          18566    18566           
  Misses         1512     1512           
  Partials        640      640           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trask

trask commented Apr 16, 2025

Copy link
Copy Markdown
Member

ah, I think the problem is that issue should be issues below, I wonder how many other repos I made that mistake in 🙈

(btw it seems weird that github issues plural but pull singular 🤷‍♂️)

--exclude "^https://github.com/open-telemetry/opentelemetry-java/(issue|pull)/\\d+$"

@trask

trask commented Apr 16, 2025

Copy link
Copy Markdown
Member

Oddly though, if you navigate to #4775 you consistently get a 500 from github, despite it indeed being the correct link to the PR. To verify the correctness, you can separately search for that specific PR and click on it from the search results to get the same result!

eek

@jack-berg

jack-berg commented Apr 16, 2025

Copy link
Copy Markdown
Member Author

(btw it seems weird that github issues plural but pull singular 🤷‍♂️)

Yeah that's terrible.

I pushed a commit to update it to plural in this repo.

@trask

trask commented Apr 16, 2025

Copy link
Copy Markdown
Member

I pushed a link to update it to plural in this repo.

thanks, yeah, I'll go check other repos

@jack-berg
jack-berg merged commit 4e457f7 into open-telemetry:main Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants