Fix link checker - #7282
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7282 +/- ##
=========================================
Coverage 89.61% 89.61%
Complexity 6858 6858
=========================================
Files 780 780
Lines 20718 20718
Branches 2020 2020
=========================================
Hits 18566 18566
Misses 1512 1512
Partials 640 640 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
ah, I think the problem is that (btw it seems weird that github |
Member
trask
approved these changes
Apr 16, 2025
Member
Author
Yeah that's terrible. I pushed a commit to update it to plural in this repo. |
Member
thanks, yeah, I'll go check other repos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build has been failing due to this for a while.
The link check config is meant to exclude links to issues / PRs for performance reasons, but this one slipped through the cracks.
Oddly though, if you navigate to #4775 you consistently get a 500 from github, despite it indeed being the correct link to the PR. To verify the correctness, you can separately search for that specific PR and click on it from the search results to get the same result!
Weird. Anyway, fixing it so its properly excluded 🤷