Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle/actions action to v4 #6618

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 3, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
gradle/actions action major v3 -> v4
gradle/actions action major v3.5.0 -> v4.0.0

Release Notes

gradle/actions (gradle/actions)

v4

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team August 3, 2024 22:39
@breedx-splk
Copy link
Contributor

This is a breaking change. I'm tackling it first in contrib with open-telemetry/opentelemetry-java-contrib#1401.

@renovate renovate bot force-pushed the renovate/gradle-actions-4.x branch from 1d22632 to cebab1f Compare August 7, 2024 18:04
@breedx-splk breedx-splk self-assigned this Aug 7, 2024
Copy link
Contributor Author

renovate bot commented Aug 7, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (5be177d) to head (a355f02).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6618   +/-   ##
=========================================
  Coverage     90.19%   90.19%           
+ Complexity     6281     6280    -1     
=========================================
  Files           697      697           
  Lines         18903    18903           
  Branches       1852     1852           
=========================================
  Hits          17050    17050           
- Misses         1281     1282    +1     
+ Partials        572      571    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-berg check my work. :) Thanks!

uses: gradle/actions/setup-gradle@v4
# skipping release branches because the versions in those branches are not snapshots
# (also this skips pull requests)
if: ${{ github.ref_name == 'main' && github.repository == 'open-telemetry/opentelemetry-java' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This duplication is unfortunate.. Nice to only have to write the condition once

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's true. Maybe down the road we can use a variable for this? I dunno.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @breedx-splk!

@jack-berg jack-berg merged commit e8b50c6 into main Aug 8, 2024
18 checks passed
@jack-berg jack-berg deleted the renovate/gradle-actions-4.x branch August 8, 2024 20:22
breedx-splk added a commit to breedx-splk/opentelemetry-java that referenced this pull request Aug 12, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jason Plumb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants