-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle/actions action to v4 #6618
Conversation
This is a breaking change. I'm tackling it first in contrib with open-telemetry/opentelemetry-java-contrib#1401. |
1d22632
to
cebab1f
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6618 +/- ##
=========================================
Coverage 90.19% 90.19%
+ Complexity 6281 6280 -1
=========================================
Files 697 697
Lines 18903 18903
Branches 1852 1852
=========================================
Hits 17050 17050
- Misses 1281 1282 +1
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jack-berg check my work. :) Thanks!
uses: gradle/actions/setup-gradle@v4 | ||
# skipping release branches because the versions in those branches are not snapshots | ||
# (also this skips pull requests) | ||
if: ${{ github.ref_name == 'main' && github.repository == 'open-telemetry/opentelemetry-java' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This duplication is unfortunate.. Nice to only have to write the condition once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's true. Maybe down the road we can use a variable for this? I dunno.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @breedx-splk!
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jason Plumb <[email protected]>
This PR contains the following updates:
v3
->v4
v3.5.0
->v4.0.0
Release Notes
gradle/actions (gradle/actions)
v4
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.