Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nullable from file config Factory contract #6612

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

jack-berg
Copy link
Member

Originally I reached a misguided conclusion that the file config Factory interface needed its model argument to be nullable. This PR fixes that, simplifying the implementation quite a bit in the process.

Originally discussed here: #6493 (comment)

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 83.72093% with 7 lines in your changes missing coverage. Please review.

Project coverage is 90.18%. Comparing base (0ffe15c) to head (1543663).

Files Patch % Lines
...incubator/fileconfig/LogRecordExporterFactory.java 0.00% 1 Missing ⚠️
...ncubator/fileconfig/LogRecordProcessorFactory.java 85.71% 1 Missing ⚠️
...on/incubator/fileconfig/MetricExporterFactory.java 0.00% 1 Missing ⚠️
...sion/incubator/fileconfig/MetricReaderFactory.java 80.00% 1 Missing ⚠️
...extension/incubator/fileconfig/SamplerFactory.java 0.00% 1 Missing ⚠️
...sion/incubator/fileconfig/SpanExporterFactory.java 0.00% 1 Missing ⚠️
...ion/incubator/fileconfig/SpanProcessorFactory.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6612      +/-   ##
============================================
- Coverage     90.19%   90.18%   -0.02%     
+ Complexity     6281     6260      -21     
============================================
  Files           697      697              
  Lines         18903    18871      -32     
  Branches       1852     1843       -9     
============================================
- Hits          17050    17019      -31     
  Misses         1281     1281              
+ Partials        572      571       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jack-berg jack-berg merged commit 56e7ebe into open-telemetry:main Aug 8, 2024
18 checks passed
breedx-splk pushed a commit to breedx-splk/opentelemetry-java that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants