add otel.instrumentation.http.server.add-server-attributes

[zeitlinger]

Background:

• exploring different options for making it easier to opt-in to server.address and server.port for http.server.request.duration
• these 2 attributes are special in that they allow the creation of a service graph - for services that don't send spans
• the best opt-in mechanism should be implemented in all languages

Alternatives:

• waiting for file config to be available
  • can configure views that control attributes to include
  • have to mention all attributes, not just opt-in
• add the same option to instrumentation
  • seemed complicated to do - but will get easier due to config properties support for spring starter clients opentelemetry-java-instrumentation#11605
  • tried for python: add OTEL_PYTHON_HTTP_SERVER_REQUEST_DURATION_SERVER_ATTRIBUTES_ENABLED flag  opentelemetry-python-contrib#2597
• add a more generic option otel.metrics.opt-in=http.server.request.duration=server.address;server.port
  • separator ; is a bit odd, but , is already used to have entries for multiple metrics
• create a distribution
  • feels excessive

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (a686280) to head (f3f4142).

Files	Patch %	Lines
...nfigure/AutoConfiguredOpenTelemetrySdkBuilder.java	0.00%	16 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6520      +/-   ##
============================================
- Coverage     90.65%   90.57%   -0.09%     
  Complexity     6227     6227              
============================================
  Files           678      678              
  Lines         18659    18676      +17     
  Branches       1842     1843       +1     
============================================
  Hits          16915    16915              
- Misses         1187     1203      +16     
- Partials        557      558       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trask]

can you explain what problem this is solving? thanks

[jkwatson]

I don't think this belongs in our core SDK autoconfigure. This looks to be an instrumentation-specific option. Let's talk about the right place for this configuration in a SIG meeting.

[jack-berg]

We've added the first instrumentation configuration options in file configuration here: open-telemetry/opentelemetry-configuration#91

Separately, this does not belong as a core SDK configuration.

[jkwatson]

@zeitlinger is there any reason to keep this open, given that both maintainers do not believe this is appropriate to build into the core repo?

[zeitlinger]

No