Stabilize explicit bucket boundaries advice API #5897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
breedx-splk
reviewed
Oct 10, 2023
api/all/src/main/java/io/opentelemetry/api/metrics/DoubleHistogramBuilder.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkDoubleHistogram.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Oct 11, 2023
…y-java into stabilize-bucket-boundary-advice
|
If there is no additional feedback I'll merge this tomorrow. |
|
@mateuszrzeszutek Does this work outside of (AutoConfigured)OpenTelemetrySdk + instanceof check? The instrumentation agent setups an OpenTelemetry instance that provides this builder. It doesn't expose/implement the interface, and there's no handle to get the agentBuilder field to configure it there. |
|
hi @nluk! oh yes, I believe support for this will need to be added in the OpenTelemetry API bridge that the instrumentation agent uses. can you open an issue for this at https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #5848.
The explicit bucket boundaries advice API is now stable: open-telemetry/opentelemetry-specification#3694