Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update semantic and resource attributes for spec v0.15.0 #4938

Merged
merged 3 commits into from
Nov 12, 2022
Merged

Update semantic and resource attributes for spec v0.15.0 #4938

merged 3 commits into from
Nov 12, 2022

Conversation

jkwatson
Copy link
Contributor

No description provided.

@jkwatson jkwatson requested a review from a team November 11, 2022 03:31
jkwatson
jkwatson commented Nov 11, 2022
View reviewed changes
semconv/src/main/java/io/opentelemetry/semconv/trace/attributes/SemanticAttributes.java
public static final AttributeKey<String> EXCEPTION_STACKTRACE = stringKey("exception.stacktrace");

/** The name identifies the event. */
public static final AttributeKey<String> EVENT_NAME = stringKey("event.name");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm starting to wonder if maybe we should split the files out by type...i.e. event/span/metric

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe... the counter argument is that attributes may overlap between signals and are expected to have the same semantics. I.e. MetricAttributes.HTTP_METHOD, SpanAttributes.HTTP_METHOD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we could annotate the attributes with some kind of indication on which signals they should be used with?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something to think about. I don't want to jump in any direction until things stabilize a bit more, though

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

Base: 91.02% // Head: 91.02% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (72c1b76) compared to base (aadcca8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #4938   +/-   ##
=========================================
  Coverage     91.02%   91.02%           
+ Complexity     4840     4839    -1     
=========================================
  Files           546      546           
  Lines         14439    14441    +2     
  Branches       1395     1395           
=========================================
+ Hits          13143    13145    +2     
  Misses          893      893           
  Partials        403      403
Impacted Files Coverage Δ
...emconv/resource/attributes/ResourceAttributes.java 100.00% <100.00%> (ø)
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 94.11% <0.00%> (-5.89%) ⬇️
...metry/sdk/logs/export/BatchLogRecordProcessor.java 89.70% <0.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkwatson
Copy link
Contributor Author

let's hold off until we can figure out how to get the script to do what we want.

@jkwatson jkwatson mentioned this pull request Nov 11, 2022
Closed
@jkwatson jkwatson force-pushed the jw/update_015_semconv branch from 787ced3 to 72c1b76 Compare November 12, 2022 06:26
@jkwatson jkwatson merged commit ea7883b into open-telemetry:main Nov 12, 2022
@jkwatson jkwatson deleted the jw/update_015_semconv branch November 12, 2022 23:06
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
@jkwatson @dmarkwat
Update semantic and resource attributes for spec v0.15.0 (open-teleme…
cd5d0e0 
…try#4938)

* Update semantic and resource attributes for spec v0.15.0

* explicitly exclude resource attributes

* remove more resources, include deprecated tags and attributes
@marcalff marcalff mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkwatson @jack-berg