OpenTracing Shim: Full multiple parent support. - #4916
Merged
jack-berg merged 6 commits intoNov 9, 2022
Conversation
This includes: * The Baggage union of ALL parents is used. * All parents are added as Links, in order to preserve the OpenTracing reference type as an attribute (either CHILD_OF or FOLLOWS_FROM).
Codecov ReportBase: 90.83% // Head: 90.98% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4916 +/- ##
============================================
+ Coverage 90.83% 90.98% +0.14%
+ Complexity 4857 4830 -27
============================================
Files 556 545 -11
Lines 14475 14415 -60
Branches 1410 1388 -22
============================================
- Hits 13149 13116 -33
+ Misses 908 895 -13
+ Partials 418 404 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Nov 4, 2022
jack-berg
left a comment
Member
There was a problem hiding this comment.
Couple of minor suggestions but looks good
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…m/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @jack-berg - applied the feedback. The only remaining item is the |
jack-berg
approved these changes
Nov 8, 2022
mateuszrzeszutek
approved these changes
Nov 9, 2022
jkwatson
approved these changes
Nov 9, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
* Full multiple parent support. This includes: * The Baggage union of ALL parents is used. * All parents are added as Links, in order to preserve the OpenTracing reference type as an attribute (either CHILD_OF or FOLLOWS_FROM). * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Update opentracing-shim/src/main/java/io/opentelemetry/opentracingshim/SpanBuilderShim.java Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> * Apply feedback. * More feedback. Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes:
Fixes #4906
Fixes #4907