Adds Graal hints for the shaded dependencies - #4832
Conversation
|
|
|
@marcingrzejszczak Could you please update the PR and test it with the file moved to |
trask
left a comment
There was a problem hiding this comment.
thx @marcingrzejszczak! is there any strategy for automating this / keeping it up-to-date over time? if there's no way to automate, it would be great if you could add a test for it, so that we don't accidentally introduce regressions later on
|
It is possible to run JUnit test on native via https://github.com/graalvm/native-build-tools. You can just reuse existing tests or write a simple integration one that runs on native. It requires a JVM distribution with |
|
I've added tests and a Github Action build |
|
I've added tests and an additional github action check for graal |
|
@marcingrzejszczak can you try |
Codecov ReportBase: 90.79% // Head: 90.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4832 +/- ##
============================================
+ Coverage 90.79% 90.83% +0.04%
- Complexity 4844 4851 +7
============================================
Files 555 555
Lines 14438 14451 +13
Branches 1405 1409 +4
============================================
+ Hits 13109 13127 +18
+ Misses 910 906 -4
+ Partials 419 418 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Is there anything else to be done here to merge this? |
jack-berg
left a comment
There was a problem hiding this comment.
Couple of small comments, but looks good. Thanks!
|
Changes got applied, thanks for the review! |
Does this mean that |
|
Since this got merged that means that indeed it does work with Native. You can check my post on Spring.io where I demonstrate that - https://spring.io/blog/2022/10/12/observability-with-spring-boot-3#running-it-all-together-with-aot-support |
we've noticed that the shaded jctools do not work with Graal out of the box. When trying to run the native image we get the following exception
That's because the shaded dependencies are missing the
META-INF/native-image/reflect-config.json. I followed the path taken by rsocket (rsocket/rsocket-java@f15c14a).cc @sdeleuze