update to semantic conventions version 1.13.0 - #4766
Conversation
Codecov ReportBase: 90.77% // Head: 90.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4766 +/- ##
=========================================
Coverage 90.77% 90.78%
- Complexity 4817 4835 +18
=========================================
Files 551 554 +3
Lines 14364 14415 +51
Branches 1397 1399 +2
=========================================
+ Hits 13039 13086 +47
- Misses 909 910 +1
- Partials 416 419 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| /** Another IP-based protocol. */ | ||
| public static final String IP = "ip"; | ||
| /** Unix Domain socket. See below. */ | ||
| public static final String UNIX = "unix"; |
There was a problem hiding this comment.
the removal of these is a non-backwards compatible breaking change. Not sure what we should do about it, though.
There was a problem hiding this comment.
I think we could modify the generator around the lines 87-88 so that it'd detect if it's about to output NetTransportValues and if so, add these two deprecated values as well.
There was a problem hiding this comment.
are you ok with adding this as a followup? I'm not sure I see exactly how this would work (my jinja skills are very poor).
There was a problem hiding this comment.
never mind. I figured it out. added them as deprecated here.
| * @deprecated this item has been removed as of 1.13.0 of the semantic conventions. Please use {@link SemanticAttributes#HTTP_REQUEST_CONTENT_LENGTH} instead. | ||
| */ | ||
| @Deprecated | ||
| public static final AttributeKey<Long> HTTP_REQUEST_CONTENT_LENGTH_UNCOMPRESSED = |
There was a problem hiding this comment.
There's several more of those:
HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSEDHTTP_HOSTNET_PEER_IPNET_PEER_PORTNET_HOST_IP
Can you add these as well?
There was a problem hiding this comment.
Is our general practice to retain deleted attributes with @Deprecated for a single release cycle, indefinitely, some other schedule?
There was a problem hiding this comment.
Good question -- I think a single release cycle is fine, it lets whoever's using the lib replace those deprecated usages.
There was a problem hiding this comment.
good catch, although NET_PEER_PORT is still here. updated.
There was a problem hiding this comment.
Looks like HTTP_RESPONSE_CONTENT_LENGTH_UNCOMPRESSED is still missing.
There was a problem hiding this comment.
whoops. missed request vs. response. added.
| /** Another IP-based protocol. */ | ||
| public static final String IP = "ip"; | ||
| /** Unix Domain socket. See below. */ | ||
| public static final String UNIX = "unix"; |
There was a problem hiding this comment.
I think we could modify the generator around the lines 87-88 so that it'd detect if it's about to output NetTransportValues and if so, add these two deprecated values as well.
3 participants
No description provided.