Merge otlp exporters #4499
Merge otlp exporters #4499
Conversation
jack-berg
commented
May 27, 2022
jack-berg
commented
- Merge otlp http trace and metric exporters into :exporters:otlp:all
- Merge otlp http log exporter into :exporters:otlp:logs
| @@ -324,4 +327,29 @@ void configuresGlobal() { | |||
| assertThat(server.metricRequests).isNotEmpty(); | |||
| }); | |||
| } | |||
|
|
|||
| static void shutdownGlobalSdk() { | |||
There was a problem hiding this comment.
I merged the testOtlpGrpc and testOtlpHttp test sets, but ran into some problems because both test suites had a test that sets up GlobalOpenTelemetry with a periodic metric reader that continues to export after the test is over and the test grpc / http server is shutdown.
The solution I came up with is to use reflection to obtain OpenTelemetrySdk from GlobalOpenTelemetry and call shutdown.
We might consider adding a utility to this to the sdk-testing in case users need to set up GlobalOpenTelemetry for some reason, and need to cleanup after.
Codecov Report
@@ Coverage Diff @@
## main #4499 +/- ##
============================================
- Coverage 90.06% 90.01% -0.06%
Complexity 5040 5040
============================================
Files 578 578
Lines 15553 15553
Branches 1498 1498
============================================
- Hits 14008 14000 -8
- Misses 1083 1090 +7
- Partials 462 463 +1
Continue to review full report at Codecov.
|
