Skip to content

Fix delta intervals - #4437

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
jack-berg:fix-delta-intervals
May 16, 2022
Merged

Fix delta intervals#4437
jack-berg merged 1 commit into
open-telemetry:mainfrom
jack-berg:fix-delta-intervals

Conversation

@jack-berg

@jack-berg jack-berg commented May 5, 2022

Copy link
Copy Markdown
Member

Resolves #4400.

@codecov

codecov Bot commented May 5, 2022

Copy link
Copy Markdown

Codecov Report

Merging #4437 (5f472a6) into main (8659a82) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4437      +/-   ##
============================================
+ Coverage     90.09%   90.12%   +0.03%     
- Complexity     5000     5003       +3     
============================================
  Files           569      569              
  Lines         15438    15435       -3     
  Branches       1488     1487       -1     
============================================
+ Hits          13909    13911       +2     
+ Misses         1065     1061       -4     
+ Partials        464      463       -1     
Impacted Files Coverage Δ
...trics/internal/state/MeterProviderSharedState.java 100.00% <ø> (ø)
...io/opentelemetry/sdk/metrics/SdkMeterProvider.java 100.00% <100.00%> (ø)
.../sdk/metrics/internal/export/RegisteredReader.java 76.47% <100.00%> (+5.04%) ⬆️
...rics/internal/state/AsynchronousMetricStorage.java 93.47% <100.00%> (-0.14%) ⬇️
...nternal/state/DefaultSynchronousMetricStorage.java 78.26% <100.00%> (-0.32%) ⬇️
.../metrics/internal/state/TemporalMetricStorage.java 100.00% <100.00%> (ø)
...telemetry/sdk/trace/export/BatchSpanProcessor.java 92.36% <0.00%> (-0.70%) ⬇️
.../opentelemetry/exporter/prometheus/Serializer.java 86.44% <0.00%> (+0.42%) ⬆️
...y/exporter/internal/marshal/CodedOutputStream.java 71.00% <0.00%> (+1.18%) ⬆️
...exporter/jaeger/MarshalerCollectorServiceGrpc.java 90.47% <0.00%> (+4.76%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8659a82...5f472a6. Read the comment docs.

@jack-berg
jack-berg force-pushed the fix-delta-intervals branch from 739cfc2 to 5f472a6 Compare May 13, 2022 18:29
@jack-berg
jack-berg marked this pull request as ready for review May 13, 2022 18:29
@jack-berg
jack-berg requested a review from a user May 13, 2022 18:29
@jack-berg
jack-berg requested a review from Oberon00 as a code owner May 13, 2022 18:29
@jack-berg
jack-berg merged commit b98ce55 into open-telemetry:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavior for DELTA metric interval

2 participants