Fix logs exporter module name - #3951
Conversation
|
Codecov Report
@@ Coverage Diff @@
## main #3951 +/- ##
============================================
+ Coverage 89.81% 89.90% +0.08%
- Complexity 4195 4208 +13
============================================
Files 500 503 +3
Lines 12728 12752 +24
Branches 1230 1232 +2
============================================
+ Hits 11432 11465 +33
+ Misses 903 896 -7
+ Partials 393 391 -2
Continue to review full report at Codecov.
|
|
breedx-splk
left a comment
There was a problem hiding this comment.
Yikes. 😁 Thanks thanks.
| import java.io.InputStream; | ||
|
|
||
| // Adapted from the protoc generated code for LogsServiceGrpc. | ||
| /** Adapted from the protoc generated code for LogsServiceGrpc. */ |
There was a problem hiding this comment.
This isn't really javadoc so a comment it more appropriate. Let's revert this change
There was a problem hiding this comment.
I realized my comment was in "pending status". 🤦🏽
There was a problem hiding this comment.
There was a problem hiding this comment.
In addition, Javadoc single-line comment can not pass spotlessJavaCheck, just like this:
I don't follow this - spotless is currently passing right? Let's go ahead and revert this - this is an internal class so it doesn't need real javadoc, this is an implementation detail comment targeted at code authors, not docs for end users. We like to make that distinction where possible.
There was a problem hiding this comment.
I see, already revert
| import java.io.InputStream; | ||
|
|
||
| // Adapted from the protoc generated code for LogsServiceGrpc. | ||
| /** Adapted from the protoc generated code for LogsServiceGrpc. */ |
There was a problem hiding this comment.
I think @anuraaga had deliberately not made this a Javadoc comment. Anuraag, can you confirm?
Fix logs exporter module name and description