Add config option for queue poll wait time #2969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbandadd
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
|
|
|
I realized we probably do want to tweak the polling strategy. Can you share the code you've been experimenting with for signalling? |
|
@anuraaga This is what I was playing with https://github.com/sbandadd/opentelemetry-java/pull/1/files. |
bogdandrutu
reviewed
Mar 3, 2021
| @@ -40,6 +40,7 @@ | |||
| void configureTracerProvider() { | |||
| Map<String, String> properties = new HashMap<>(); | |||
| properties.put("otel.bsp.schedule.delay", "100000"); | |||
| properties.put("otel.bsp.queue.poll.wait.time", "100"); | |||
There was a problem hiding this comment.
This probably needs to go in specs?
Comment on lines
-191
to
+196
| ReadableSpan lastElement = queue.poll(100, TimeUnit.MILLISECONDS); | ||
| ReadableSpan lastElement = queue.poll(queuePollWaitTimeNanos, TimeUnit.NANOSECONDS); |
There was a problem hiding this comment.
Can you document the motivation? We don't want to add configuration for everything unless there is a good use-case to configure that.
|
We are looking for better alternatives. I don't think this is needed anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.