DefaultTracer: Fix noParent being ignored after explicit parent. #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
pavolloffay,
thisthat and
tylerbenson
as code owners
Oberon00
commented
Sep 2, 2020
| @@ -114,6 +114,22 @@ void testSpanContextPropagation_fromContext() { | |||
| assertThat(span.getContext()).isSameAs(spanContext); | |||
| } | |||
|
|
|||
| @Test | |||
| void testSpanContextPropagation_fromContextAfterNoParent() { | |||
There was a problem hiding this comment.
I believed this test would fail before this PR initially, but it's the other way round. Still adding this test to cover this case too.
thisthat
approved these changes
Sep 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
+ Coverage 86.64% 86.66% +0.01%
Complexity 1404 1404
============================================
Files 163 163
Lines 5535 5535
Branches 551 551
============================================
+ Hits 4796 4797 +1
Misses 542 542
+ Partials 197 196 -1
Continue to review full report at Codecov.
|
iNikem
approved these changes
Sep 2, 2020
arminru
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1611 (comment)