Unify compression configuration for exporters - #4775
Conversation
Codecov ReportBase: 90.79% // Head: 90.92% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4775 +/- ##
============================================
+ Coverage 90.79% 90.92% +0.13%
+ Complexity 4839 4808 -31
============================================
Files 554 545 -9
Lines 14422 14340 -82
Branches 1402 1383 -19
============================================
- Hits 13094 13039 -55
+ Misses 910 894 -16
+ Partials 418 407 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
left a comment
There was a problem hiding this comment.
Looks good, but think we should keep the current behavior for the zipkin exporter and leave compression enabled by default.
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@jkwatson please take a look when you have a chance |
jkwatson
left a comment
There was a problem hiding this comment.
Just one small javadoc nit that would be nice to add.
The
GrpcExporterBuilderenables compression whennoneis configured.The
OkHttpExporterBuilderhas no way to disable compression vianoneonce it's set (which seems wrong for a mutable builder).The
JaegerGrpcSpanExporterBuilderandZipkinSpanExporterBuilderhave no configuration for compression at all.noneinGrpcExporterBuildernoneinOkHttpExporterBuilderJaegerGrpcSpanExporterBuilderZipkinSpanExporterBuilderNote: All exporters except
ZipkinSpanExporterBuilderdefault to compression disabled. In Zipkin the internally usedHttpSender.BuilderhascompressionEnabled = true. This behavior was not changed, so theZipkinSpanExporterBuilderstill enables compression by default.Resolves #1652 Add GZip encoding support to Zipkin