Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default bucket boundaries for explicit bucket histogram are different from specification #4665

Closed
jack-berg opened this issue Aug 4, 2022 · 2 comments · Fixed by #4684 or #4819
Closed
Labels
Bug Something isn't working

Comments

@jack-berg
Copy link
Member

The java default explicit bucket histogram bucket boundaries are:

[5, 10, 25, 50, 75, 100, 250, 500, 750, 1_000, 2_500, 5_000, 7_500, 10_000]

But according to the spec should be:

[ 0, 5, 10, 25, 50, 75, 100, 250, 500, 1_000 ]

@jack-berg
Copy link
Member Author

Reopening this since we reverted the fix in #4736.

Need to wait for a resolution on spec PR #2770.

@jack-berg jack-berg reopened this Sep 13, 2022
@jack-berg
Copy link
Member Author

The spec has changed the default boundaries to [ 0, 5, 10, 25, 50, 75, 100, 250, 500, 750, 1000, 2500, 5000, 7500, 10000 ].

Note that the only difference between the new defaults and our current defaults is that the spec has a 0 bucket. We should be able to add this bucket without issue because negative values currently aren't allowed so adding it should be functionally equivalent to what we currently do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
1 participant