Add context leak debugger #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While we discussed that the gRPC context override is a strange API how about using it here so it affects all instrumentation, not just executor? This change reminds me a lot of brave's strict scope decorator, which we should copy as much as we can from |
iNikem
approved these changes
Aug 1, 2020
|
Here's an example of a context leak log for the sporadic failure in #430: |
|
Did you happen to think about the more generic approach? Maybe in a future PR? |
Oh sorry I forgot about that. Yes, we should do that, especially given our concerns about context propagation across threads. I just opened #874 to track. |
anuraaga
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @iNikem's findings in #787.
E.g. in #787, @iNikem found that the context leak sometimes leaks into the Tomcat thread pool via
AsyncContext.dispatch(). And so to prevent that particular leak we could instrumentAsyncContext.dispatch()and push an empty context into scope.This debug option (which is enabled by default when running tests) will hopefully help to track down the source of these leaks, and then we can see if we can fix them (similar to
AsyncContext.dispatch()example above).