Workaround for #787 #814
Merged
Workaround for #787 #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
trask and
tylerbenson
as code owners
iNikem
commented
Jul 27, 2020
| @@ -115,7 +114,7 @@ class Netty41ClientTest extends HttpClientTest { | |||
| "error.type" AbstractChannel.AnnotatedConnectException.name | |||
| "error.stack" String | |||
| // slightly different message on windows | |||
| "error.msg" ~/Connection refused:( no further information:)? localhost\/[0-9.:]+:$UNUSABLE_PORT/ | |||
| "error.msg" ~/Connection refused:( no further information:)? localhost\/\[?[0-9.:]+\]?:$UNUSABLE_PORT/ | |||
There was a problem hiding this comment.
This is to allow both IPv4 and IPv6 addresses. GH Action has both.
trask
approved these changes
Jul 27, 2020
Comment on lines
+26
to
+28
| import java.util.concurrent.ExecutionException | ||
| import java.util.concurrent.TimeUnit | ||
| import java.util.concurrent.TimeoutException |
This was referenced Aug 1, 2020
Closed
Closed
|
@iNikem, if we are in agreement that this is no longer just temporary workaround, let's rename (since there are several links to this issue and so is a bit confusing)? |
|
Do you want to rename PR? Or is it sufficient to change commend in code? |
|
I'd suggest both, but if you prefer not to rename the PR that's ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is NOT a proper fix, but it will at least unblock GitHub Actions