Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spring Web 6 in library instrumentation #7551

Merged
merged 3 commits into from
Jan 13, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,16 @@ dependencies {
compileOnly("org.springframework:spring-web:3.1.0.RELEASE")

testLibrary("org.springframework:spring-web:3.1.0.RELEASE")
latestDepTestLibrary("org.springframework:spring-web:5.+")

testImplementation(project(":testing-common"))
testImplementation("io.opentelemetry:opentelemetry-sdk-testing")
}

val latestDepTest = findProperty("testLatestDeps") as Boolean

// spring 6 requires java 17
if (latestDepTest) {
otelJava {
minJavaVersionSupported.set(JavaVersion.VERSION_17)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@

import io.opentelemetry.instrumentation.api.instrumenter.http.HttpClientAttributesGetter;
import java.io.IOException;
import java.lang.invoke.MethodHandle;
import java.lang.invoke.MethodHandles;
import java.lang.invoke.MethodType;
import java.util.List;
import javax.annotation.Nullable;
import org.springframework.http.HttpRequest;
import org.springframework.http.HttpStatus;
import org.springframework.http.client.ClientHttpResponse;

enum SpringWebHttpAttributesGetter
Expand Down Expand Up @@ -41,13 +43,60 @@ public String flavor(HttpRequest httpRequest, @Nullable ClientHttpResponse clien
return null;
}

@Nullable private static final MethodHandle GET_STATUS_CODE;

@Nullable private static final MethodHandle STATUS_CODE_VALUE;

static {
MethodHandle getStatusCode = null;
MethodHandle statusCodeValue = null;
Class<?> httpStatusCodeClass = null;

MethodHandles.Lookup lookup = MethodHandles.publicLookup();

try {
httpStatusCodeClass = Class.forName("org.springframework.http.HttpStatusCode");
} catch (ClassNotFoundException e) {
try {
httpStatusCodeClass = Class.forName("org.springframework.http.HttpStatus");
} catch (ClassNotFoundException ignored) {
// ignored
}
}

if (httpStatusCodeClass != null) {
try {
getStatusCode =
lookup.findVirtual(
ClientHttpResponse.class,
"getStatusCode",
MethodType.methodType(httpStatusCodeClass));
statusCodeValue =
lookup.findVirtual(httpStatusCodeClass, "value", MethodType.methodType(int.class));
} catch (NoSuchMethodException | IllegalAccessException ignored) {
// ignored
}
}

GET_STATUS_CODE = getStatusCode;
STATUS_CODE_VALUE = statusCodeValue;
}

@Override
public Integer statusCode(
HttpRequest httpRequest, ClientHttpResponse clientHttpResponse, @Nullable Throwable error) {

if (GET_STATUS_CODE == null || STATUS_CODE_VALUE == null) {
return null;
}

try {
return clientHttpResponse.getStatusCode().value();
Object statusCode = GET_STATUS_CODE.invoke(clientHttpResponse);
return (int) STATUS_CODE_VALUE.invoke(statusCode);
} catch (IOException e) {
return HttpStatus.INTERNAL_SERVER_ERROR.value();
return 500;
mateuszrzeszutek marked this conversation as resolved.
Show resolved Hide resolved
} catch (Throwable e) {
return null;
}
}

Expand Down