Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource injection for class loader getResourceAsStream #7476

Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Dec 27, 2022

In #7447 injected resource is opened with class loader getResourceAsStream. This works only in class loaders where getResourceAsStream delegates to getResource. This is not the case with all class loaders, for example tomcat class loader does not do this. Because of this we also need to instrument class loader getResourceAsStream.

@laurit laurit requested a review from a team December 27, 2022 09:28
@mateuszrzeszutek mateuszrzeszutek merged commit fe540ea into open-telemetry:main Jan 2, 2023
@laurit laurit deleted the getresourceasstream-inject branch July 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants