Instrument JMS 3.0 (Jakarta) #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
trask
approved these changes
Jan 12, 2023
Comment on lines
+17
to
+22
| pass { | ||
| group.set("jakarta.jms") | ||
| module.set("jakarta.jms-api") | ||
| versions.set("(,3)") | ||
| assertInverse.set(true) | ||
| } |
trask
added a commit
that referenced
this pull request
Jan 12, 2023
Part of #7203 The instrumentation is 100% copy-pasted, tests are rewritten from scratch in Java because of way too many class name changes. Depends on #7418 Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were so many changes in the tests that extracting a base class wouldn't really improve the readability; so I just reimplemented them in Java.
The instrumentation itself is pretty much a copy-paste of the
jms-1.1instrumentation, withs/javax/jakarta/applied.