Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate messaging.kafka.message.offset in all kafka instrumentations #7374

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Populate messaging.kafka.message.offset in all kafka instrumentations #7374

merged 2 commits into from
Dec 10, 2022

Conversation

mateuszrzeszutek
Copy link
Member

No description provided.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team December 9, 2022 08:57
@mateuszrzeszutek mateuszrzeszutek changed the title Populate messaging.kafka.message.offset in all kafka instrumentations Populate messaging.kafka.message.offset in all kafka instrumentations Dec 9, 2022
@mateuszrzeszutek mateuszrzeszutek added this to the v1.21.0 milestone Dec 9, 2022
trask
trask approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many kafka tests 😅

@trask trask merged commit ebb0141 into open-telemetry:main Dec 10, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the kafka-message-offset branch January 4, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mateuszrzeszutek @trask @laurit