Support Spring Kafka 3 #7271
Merged
Support Spring Kafka 3 #7271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Nov 23, 2022
...n/java/io/opentelemetry/instrumentation/spring/kafka/v2_7/InstrumentedRecordInterceptor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Nov 23, 2022
...n/java/io/opentelemetry/instrumentation/spring/kafka/v2_7/InstrumentedRecordInterceptor.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
spring-kafka-3
branch
from
f6a33bd to
70ca857
Compare
laurit
approved these changes
Nov 25, 2022
mateuszrzeszutek
force-pushed
the
spring-kafka-3
branch
from
70ca857 to
1d23ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7265
I took a look at the new Observation API, and I think that it still makes sense to continue using the interceptors to implement this instrumentation: they implement the OTel spec (which includes way more attributes than the default observation convention implemented in Spring), and cooperate with the Kafka client instrumentation and link the receive and process spans together. And it's quite a simple change in one of our interceptors, instead of rewriting everything.
(Draft because Spring Boot 3 hasn't released yet, and it is required to run the tests. If we're not in a hurry this PR can wait a bit for that)