Fix the boms #7252
Merged
Fix the boms #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Nov 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
the 1.20.1 instrumentation boms are busted, as they are missing versions for their nested boms (sort of surprised maven central didn't reject them), e.g. ``` <dependency> <groupId>io.opentelemetry</groupId> <artifactId>opentelemetry-bom</artifactId> <type>pom</type> <scope>import</scope> </dependency> ``` https://repo.maven.apache.org/maven2/io/opentelemetry/instrumentation/opentelemetry-instrumentation-bom/1.20.1/opentelemetry-instrumentation-bom-1.20.1.pom deserves another patch release
trask
added a commit
that referenced
this pull request
Nov 21, 2022
Clean cherry-pick of #7252 to the `release/v1.20.x` branch. Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the 1.20.1 instrumentation boms are busted, as they are missing versions for their nested boms (sort of surprised maven central didn't reject them), e.g.
https://repo.maven.apache.org/maven2/io/opentelemetry/instrumentation/opentelemetry-instrumentation-bom/1.20.1/opentelemetry-instrumentation-bom-1.20.1.pom
deserves another patch release