Add deprecation cycle for removed methods #7020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Seems good to me. It feels a little weird reintroducing them after a release was cut without them, doesn't it?
|
ya, I'm planning to backport this to v1.19.x branch and release v1.19.2, it was a mistake to remove these two methods in v1.19.1 |
Cool, I also saw the convo in slack. 👍🏻 |
breedx-splk
approved these changes
Nov 1, 2022
jack-berg
approved these changes
Nov 1, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
Methods were removed in #6892, which was backported to the 1.19.x branch and included in the 1.19.1 release.
trask
added a commit
that referenced
this pull request
Nov 1, 2022
Clean cherry-pick of #7020 to the `release/v1.19.x` branch. Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods were removed in #6892, which was backported to the 1.19.x branch and included in the 1.19.1 release.