Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert removing the mavenCentral repo from the muzzle check plugin #6937

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Revert removing the mavenCentral repo from the muzzle check plugin #6937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion gradle-plugins/src/main/kotlin/io.opentelemetry.instrumentation.muzzle-check.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ if (hasRelevantTask) {
}

fun getProjectRepositories(project: Project): List<RemoteRepository> {
return project.repositories
val projectRepositories = project.repositories
.filterIsInstance<MavenArtifactRepository>()
.map {
RemoteRepository.Builder(
Expand All @@ -181,6 +181,17 @@ fun getProjectRepositories(project: Project): List<RemoteRepository> {
it.url.toString())
.build()
}
// dependencyResolutionManagement.repositories are not being added to project.repositories,
// they need to be queries separately
if (projectRepositories.isEmpty()) {
// Manually add mavenCentral until https://github.com/gradle/gradle/issues/17295
// Adding mavenLocal is much more complicated but hopefully isn't required for normal usage of
// Muzzle.
return listOf(RemoteRepository.Builder(
"MavenCentral", "default", "https://repo.maven.apache.org/maven2/")
.build())
}
return projectRepositories
}

fun createInstrumentationClassloader(): ClassLoader {
Expand Down