Extract net.peer.{name,port} on start for CLIENT spans
#6828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
commented
Oct 7, 2022
Comment on lines
-25
to
-28
| if (response != null) { | ||
| return response.getHost().getHostName(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
The elasticsearch-rest instrumentations are the only ones that actually lost some data because of this change - but I'd argue that it's not that important, because it uses the Apache HTTP client to make all the REST calls, so you'll still have the peer name&port on the child HTTP CLIENT span.
There was a problem hiding this comment.
I'll open an issue to track this, but agree it's not that important
trask
approved these changes
Oct 10, 2022
Comment on lines
-25
to
-28
| if (response != null) { | ||
| return response.getHost().getHostName(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
I'll open an issue to track this, but agree it's not that important
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…try#6828) The [HTTP spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client) says these two attributes must be provided at span creation time - I think it makes sense to extend it over to all `net`-related instrumentations, cause these are supposed to be the logical peer name/port, which are supposed to be known before the connection is started/exchange is made.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…try#6828) The [HTTP spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client) says these two attributes must be provided at span creation time - I think it makes sense to extend it over to all `net`-related instrumentations, cause these are supposed to be the logical peer name/port, which are supposed to be known before the connection is started/exchange is made.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…try#6828) The [HTTP spec](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md#http-client) says these two attributes must be provided at span creation time - I think it makes sense to extend it over to all `net`-related instrumentations, cause these are supposed to be the logical peer name/port, which are supposed to be known before the connection is started/exchange is made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP spec says these two attributes must be provided at span creation time - I think it makes sense to extend it over to all
net-related instrumentations, cause these are supposed to be the logical peer name/port, which are supposed to be known before the connection is started/exchange is made.