Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add marker attribute for Logback #6652

Merged
merged 5 commits into from
Sep 22, 2022
Merged

Add marker attribute for Logback #6652

merged 5 commits into from
Sep 22, 2022

Conversation

jeanbisutti
Copy link
Member

No description provided.

@jeanbisutti jeanbisutti requested a review from a team September 19, 2022 12:53
trask
trask reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

...java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java Outdated Show resolved Hide resolved
...aagent/src/test/java/io/opentelemetry/instrumentation/logback/appender/v1_0/LogbackTest.java Outdated Show resolved Hide resolved
.../main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/OpenTelemetryAppender.java Outdated Show resolved Hide resolved
...java/io/opentelemetry/javaagent/instrumentation/logback/appender/v1_0/LogbackSingletons.java Outdated Show resolved Hide resolved
@jeanbisutti jeanbisutti requested a review from trask September 20, 2022 09:10
@trask trask mentioned this pull request Sep 21, 2022
Merged
@trask trask merged commit c42eac9 into open-telemetry:main Sep 22, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@jeanbisutti @LironKS
Add marker attribute for Logback (open-telemetry#6652)
cab9f6d
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@jeanbisutti @LironKS
Add marker attribute for Logback (open-telemetry#6652)
93b8283
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@jeanbisutti @LironKS
Add marker attribute for Logback (open-telemetry#6652)
c6954af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeanbisutti @trask @mateuszrzeszutek