Propagate client span context in doOnRequest

[jamesmartinpp]

Copying the changes from Mike W. This fixes the problem where the jaxrs and http client request spans are siblings instead of parent/child.

@mateuszrzeszutek please review

[trask]

thx @jamesmartinpp!

[trask]

jaxrs and http client request spans are siblings instead of parent/child

@jamesmartinpp which jaxrs library/version and which http client library/version is this? we may be able to update the related jaxrs client test to include the http client instrumentation to provide test coverage for this

[jamesmartinpp]

jaxrs and http client request spans are siblings instead of parent/child

@jamesmartinpp which jaxrs library/version and which http client library/version is this? we may be able to update the related jaxrs client test to include the http client instrumentation to provide test coverage for this

The client is reactor-netty and the jaxrs framework is Resteasy.

[trask]

@jamesmartinpp what versions of reactory-netty and resteasy?

[trask]

This fixes the problem where the jaxrs and http client request spans are siblings instead of parent/child.

I thought I understood this, but I'm not able to repro it, is this a jaxrs CLIENT span or a jaxrs INTERNAL span? could you include a bit more detail how to reproduce the issue? thx!

[jamesmartinpp]

@jamesmartinpp what versions of reactory-netty and resteasy?

reactor-netty v1.0.17
resteasy v3.5.0

[jamesmartinpp]

This fixes the problem where the jaxrs and http client request spans are siblings instead of parent/child.

I thought I understood this, but I'm not able to repro it, is this a jaxrs CLIENT span or a jaxrs INTERNAL span? could you include a bit more detail how to reproduce the issue? thx!

I believe this is a jaxrs CLIENT span. I'm pretty sure the relationship to the jaxrs service span is correct. I will check MIke's notes and get back to you.

[jamesmartinpp]

@trask

I believe this is a jaxrs CLIENT span. I'm pretty sure the relationship to the jaxrs service span is correct. I will check MIke's notes and get back to you.

Sorry, I was wrong. Prior to this change we are propagating the upstream service's jax-rs request spanid as the parent. So the downstream jaxrs request will use the upstream server's spanId as its parent. Making this change will propagate the http get spanId instead.

So before this change:

server1
    |
    --- client 1
    |
    --- server 2

After this change:
server1
    |
    --- client 1
            |
            --- server 2

[mateuszrzeszutek]

Just to make things a bit more clear: you're using a custom propagation method and you need doOnRequest() to have the CLIENT span context available to be able to propagate all the necessary data, right?

[jamesmartinpp]

Just to make things a bit more clear: you're using a custom propagation method and you need doOnRequest() to have the CLIENT span context available to be able to propagate all the necessary data, right?

Yes, that appears to be correct. Please let me know if this is a problem.

[trask]

@jamesmartinpp makes sense, thx