Add a JDBC-specific sanitizer property #6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
I like the flexibility that this affords. Users will be able to control the sanitization of jdbc independently from other db flavors, with the default still being to fall back to sanitization enabled. Sounds good to me.
I would argue in favor of keeping the common setting, though, since I think most users benefit from it and I don't necessarily want users to have to know the specifics of their db flavor to find the specific control.
mateuszrzeszutek
approved these changes
Aug 16, 2022
laurit
approved these changes
Aug 16, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have a jdbc-specific sanitizer property since disabling the sanitizer is a PII/data sensitivity concern.
I wouldn't mind removing the common property altogether and only supporting instrumentation-specific ones (jedis, lettuce, cassandra, etc), with the thought that users should be very clear about the scope that they are disabling for the sanitizer.
Although I can see the common property being handy in dev environments where there are no data sensitivity concerns.