Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shouldStart() call to gRPC instrumentation #6356

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Add shouldStart() call to gRPC instrumentation #6356

merged 1 commit into from
Jul 22, 2022

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Jul 21, 2022 •
edited
Loading

Resolves #6353

@XSAM XSAM force-pushed the grpc-shouldstart branch from 3c48568 to a2f4f6b Compare July 21, 2022 08:20
@XSAM XSAM marked this pull request as ready for review July 21, 2022 08:32
@XSAM XSAM requested a review from a team July 21, 2022 08:32
mateuszrzeszutek
mateuszrzeszutek approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mateuszrzeszutek mateuszrzeszutek merged commit fcda760 into open-telemetry:main Jul 22, 2022
@XSAM XSAM deleted the grpc-shouldstart branch July 22, 2022 08:47
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@XSAM @LironKS
Add shouldStart() call to gRPC instrumentation (open-telemetry#6356)
d9dc383
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@XSAM @LironKS
Add shouldStart() call to gRPC instrumentation (open-telemetry#6356)
10ae48d
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@XSAM @LironKS
Add shouldStart() call to gRPC instrumentation (open-telemetry#6356)
d16f70e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@laurit laurit laurit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated span while instrumenting a Quarkus gRPC server
3 participants
@XSAM @laurit @mateuszrzeszutek