Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture enduser.id in servlet instrumentation #6225

Merged
merged 4 commits into from
Jun 28, 2022
Merged

Capture enduser.id in servlet instrumentation #6225

merged 4 commits into from
Jun 28, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jun 27, 2022

Hopefully resolves #6203
Capture enduser.id in servlet instrumentation for servers whose instrumentation doesn't use the servlet instrumentation.

@laurit laurit requested a review from a team June 27, 2022 12:17
@mateuszrzeszutek
Copy link
Member

Can TomcatAdditionalAttributesExtractor be removed now?

trask
trask approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 3024868 into open-telemetry:main Jun 28, 2022
@laurit laurit deleted the servlet-enduser-id branch June 28, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Servlet instrumentation ignored when Undertow instrumentation is enabled
3 participants
@laurit @mateuszrzeszutek @trask