-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug: get return type in a wrong way for method instrumentation #6118
Conversation
|
@darcydai could you add a test for this? |
yes, later |
it is hard to approve |
@darcydai I created a pull request darcydai#1 for your pull request. I moved the new test into a separate method and instead of figuring out from span length checked directly whether span was still running after the method completed. WDYT? |
wow, that is more graceful than mine |
optimize test case on method instrumentation
I have merged your pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx!
After testing, @Advice.Origin("#r") can only insert a string type parameter from the constant pool.
@Advice.Origin("#r") Class<?> returnType: returnType is current class for method