Add jvm cpu metrics #6107
Merged
Add jvm cpu metrics #6107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
May 27, 2022
|
|
||
| meter | ||
| .gaugeBuilder("process.runtime.jvm.system.cpu.load_1m") | ||
| .setDescription("Average CPU load of the whole system for the last minute") |
There was a problem hiding this comment.
This definition from the semantic convention doesn't really match the the description from the OperatingSystemMXBean. It's a pretty odd calculation as it isn't bounded to the range [0,1], [0, 100] or even to [0, 100*N] where N is the number of processors.
This stack overflow post describes it as the "average is the number of waiting threads", and says the upper limit is equal to the number of threads you have.
There was a problem hiding this comment.
Isn't this the same as unix load average that is displayed for example by uptime?
jack-berg
commented
May 27, 2022
...ntime-metrics/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/Cpu.java
Outdated
Show resolved
Hide resolved
breedx-splk
approved these changes
May 27, 2022
.../java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/RuntimeMetricsInstaller.java
Show resolved
Hide resolved
laurit
approved these changes
Jun 2, 2022
trask
approved these changes
Jun 2, 2022
...ntime-metrics/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/Cpu.java
Outdated
Show resolved
Hide resolved
...ntime-metrics/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/Cpu.java
Outdated
Show resolved
Hide resolved
...ntime-metrics/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/Cpu.java
Outdated
Show resolved
Hide resolved
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflects the semantic conventions in #2292.