Implement Oracle UCP connection pool metrics #6099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
May 27, 2022
Comment on lines
82
to
92
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, "db.client.connections.usage", AbstractIterableAssert::isEmpty); | ||
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, "db.client.connections.max", AbstractIterableAssert::isEmpty); | ||
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, | ||
| "db.client.connections.pending_requests", | ||
| AbstractIterableAssert::isEmpty); |
There was a problem hiding this comment.
same question from https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/6102/files#r883947307
is there a need for waiting here vs a single assert?
laurit
commented
May 28, 2022
Comment on lines
82
to
92
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, "db.client.connections.usage", AbstractIterableAssert::isEmpty); | ||
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, "db.client.connections.max", AbstractIterableAssert::isEmpty); | ||
| testing() | ||
| .waitAndAssertMetrics( | ||
| INSTRUMENTATION_NAME, | ||
| "db.client.connections.pending_requests", | ||
| AbstractIterableAssert::isEmpty); |
There was a problem hiding this comment.
Suggested change
| testing() | |
| .waitAndAssertMetrics( | |
| INSTRUMENTATION_NAME, "db.client.connections.usage", AbstractIterableAssert::isEmpty); | |
| testing() | |
| .waitAndAssertMetrics( | |
| INSTRUMENTATION_NAME, "db.client.connections.max", AbstractIterableAssert::isEmpty); | |
| testing() | |
| .waitAndAssertMetrics( | |
| INSTRUMENTATION_NAME, | |
| "db.client.connections.pending_requests", | |
| AbstractIterableAssert::isEmpty); | |
| Set<String> metricNames = | |
| new HashSet<>( | |
| Arrays.asList( | |
| "db.client.connections.usage", | |
| "db.client.connections.max", | |
| "db.client.connections.pending_requests")); | |
| assertThat(testing().metrics()) | |
| .filteredOn( | |
| metricData -> | |
| metricData.getInstrumentationScopeInfo().getName().equals(INSTRUMENTATION_NAME) | |
| && metricNames.contains(metricData.getName())) | |
| .isEmpty(); |
@trask is this what you meant?
There was a problem hiding this comment.
ya, though maybe we also need to sleep (at least time for metric interval) before asserting
There was a problem hiding this comment.
ya, though maybe we also need to sleep (at least time for metric interval) before asserting
Hmmm, do you think we're just getting lucky now then?
There was a problem hiding this comment.
There is a sleep right before the snippet starts and you are correct, it is needed.
trask
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.