Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TimeExtractor and use internal API for setting start/end timestamps #6051

Merged
merged 2 commits into from
May 19, 2022
Merged

Remove TimeExtractor and use internal API for setting start/end timestamps #6051

merged 2 commits into from
May 19, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Replaces #6024, resolves #6014

@mateuszrzeszutek mateuszrzeszutek requested a review from a team May 17, 2022 11:49
laurit
laurit approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@laurit laurit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These spans won't always be in correct order when compared to other spans when running on jdk8 because Instant.now only has millisecond resolution in jdk8.

@mateuszrzeszutek
Copy link
Member Author

These spans won't always be in correct order when compared to other spans when running on jdk8 because Instant.now only has millisecond resolution in jdk8.

Yep -- and they also may be out of order because they're not using the same AnchoredClock as the other spans. That's one of the reasons we're making it internal, I guess.

@trask trask merged commit 512a040 into open-telemetry:main May 19, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@RashmiRam
Remove TimeExtractor and use internal API for setting start/end times…
1f56285 
…tamps (open-telemetry#6051)

* Remove TimeExtractor and use internal API for setting start/end timestamps

* code review comments
@mateuszrzeszutek mateuszrzeszutek deleted the internal-TimeExtractor branch November 18, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Instrumentation API thoughts
3 participants
@mateuszrzeszutek @trask @laurit