Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid npe in netty 4.1 instrumentation #5902

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Apr 21, 2022

Resolves #5901

@laurit laurit requested a review from a team April 21, 2022 09:14
@trask trask merged commit ceeaa1b into open-telemetry:main Apr 21, 2022
@pkgonan
Copy link

pkgonan commented Apr 22, 2022

@mateuszrzeszutek @trask
Hi, when is the release date of 1.13.1 ?

@trask
Copy link
Member

trask commented Apr 22, 2022

hi @pkgonan! we are releasing 1.13.1 soon, but this fix isn't included because it doesn't meet our criteria for patching:

In general, patch releases are only made for regressions, security vulnerabilities, memory leaks and deadlocks.

if you are looking for the latest SNAPSHOT build (which includes the fix), check out https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CONTRIBUTING.md#snapshot-builds

1.14.0 (which will have this fix) should be released ~3rd week of May

RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the netty-npe branch July 6, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when using the Aleph library (built on top of netty)
4 participants