Fix duplicate class error on Android build #5882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
https://github.com/orgs/open-telemetry/teams/java-instrumentation-maintainers do you think this warrants a patch release?
I think so. I need to test out the patch release workflow anyways.
trask
pushed a commit
that referenced
this pull request
Apr 19, 2022
Co-authored-by: Mateusz Rzeszutek <[email protected]>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to bump the OTel instrumentation versions to 1.13 in our Splunk Android instrumentation repo (signalfx/splunk-otel-android#276), got this error:
Looks like that file only appears once in the javaagent, and it's probably only a problem for the Android gradle plugin.
@open-telemetry/java-instrumentation-maintainers do you think this warrants a patch release?