Fix missing class errors #5795
Merged
Fix missing class errors #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Apr 11, 2022
|
|
||
| public static AgentLocationStrategy locationStrategy() { | ||
| return locationStrategy(null); | ||
| return LOCATION_STRATEGY; |
There was a problem hiding this comment.
Just to confirm the fix is to not pass null in this codepath?
There was a problem hiding this comment.
Yes. The problem is probably that wildfly class loader doesn't unconditionally delegate resource lookups to system loader and isn't able to find resources that are in agent jar. Previously it worked because in AgentLocationStrategy we added ClassFileLocator for all parent class loaders, which included system class loader, where the agent is initially loaded. To make resources from agent jar visible we need to add a ClassFileLocator with bootstrap proxy.
laurit
reviewed
Apr 11, 2022
|
|
||
| public static AgentLocationStrategy locationStrategy() { | ||
| return locationStrategy(null); | ||
| return LOCATION_STRATEGY; | ||
| } | ||
|
|
||
| public static AgentLocationStrategy locationStrategy(ClassLoader bootstrapProxy) { |
There was a problem hiding this comment.
I believe we can remove this method
laurit
approved these changes
Apr 11, 2022
mateuszrzeszutek
approved these changes
Apr 11, 2022
This was referenced Apr 11, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Co-authored-by: Lauri Tulmin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled #5724 into our distro to check out the startup perf improvements and ran into some smoke test failures on Wildfly 11, e.g. below stack trace.
I'll open a tracking issue to investigate why the wildfly smoke tests in this repo didn't catch this, maybe we need a bit more instrumentation (e.g. otel-api) in the servlet test app.