Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve end strategy after WithSpan method instead of before. #5756

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Apr 6, 2022

End strategies may be registered as a result of classload, e.g. reactor strategy will only be registered after reactor is classloaded since we instrument static initializer. Luckily we can just move the resolution of end strategy to after the method when any classes would have been loaded, since the end strategy isn't needed until then.

@anuraaga anuraaga requested a review from a team April 6, 2022 07:32
Comment on lines +16 to +17
// Isolated test to use clean classloader because reactor instrumentation is applied on static
// initialization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit cd725ec into open-telemetry:main Apr 7, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…elemetry#5756)

* WIP

* Resolve end strategy after WithSpan method instead of before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants