Rework context propagation to redisson async callback #5748
Conversation
There was a problem hiding this comment.
I suspect the issue is that currently we set the context we wish to use for callbacks deep in the request handling where it will get chained through other completable futures. Hopefully setting the context closer to the callback will work better.
If you could add a comment like this in the code, I think it would be helpful, otherwise it's not obvious why we wouldn't use the same wrapper for both, and tests wouldn't reveal any problem if someone tried to "simplify" this in the future.
@trask comment added, could you review |
thx 👍 |
…#5748) * Rework context propagation to redisson async callback * add comments
Lately (since release of
3.17.0?) redisson latest dep tests have been flaky https://ge.opentelemetry.io/scans/tests?search.buildOutcome=success&search.relativeStartTime=P7D&search.tags=CI&search.timeZoneId=Europe/Tallinn&tests.container=RedissonAsyncClientTest&tests.sortField=FLAKY&tests.test=test%20future%20whenComplete&tests.unstableOnly=trueI wasn't able to reproduce it. I suspect the issue is that currently we set the context we wish to use for callbacks deep in the request handling where it will get chained through other completable futures. Hopefully setting the context closer to the callback will work better.