Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with jdk17 #5598

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Run tests with jdk17 #5598

merged 1 commit into from
Mar 17, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Mar 17, 2022

No description provided.

@laurit laurit requested a review from a team March 17, 2022 10:38
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +83 to +84
// AgentClassLoader is in unnamed module of the bootstrap class loader which is
// where helper classes are also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask
Copy link
Member

trask commented Mar 17, 2022

merging b/c I'm doing some work on yml files and don't want to cause conflicts, will send separate PR to update doc

@trask trask merged commit 45bd419 into open-telemetry:main Mar 17, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the test-jdk17 branch July 6, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants